TODO items

Member Acts::AdaptiveMultiVertexFitter::State::vtxInfoMap

Does this have to be a mutable pointer?

Class Acts::AtlasBetheHeitlerApprox

This class is rather inflexible: It forces two data representations, making it a bit awkward to add a single parameterization. It would be good to generalize this at some point.

Member Acts::BinnedArrayXD< T >::object (const Vector2 &lposition, std::array< std::size_t, 3 > &bins) const final

check if we can change to triple return at once

Member Acts::BinningData::nextDirection (const Vector3 &position, const Vector3 &dir) const

check if this can be changed

Member Acts::BinUtility::nextDirection (const Vector3 &position, const Vector3 &direction, std::size_t ba=0) const

the

Class Acts::BoundarySurfaceT< volume_t >

change to one schema with BinnedArray0D

Member Acts::ConeLayer::ConeLayer (const Transform3 &transform, std::shared_ptr< const ConeBounds > cbounds, std::unique_ptr< SurfaceArray > surfaceArray, double thickness=0., std::unique_ptr< ApproachDescriptor > ade=nullptr, LayerType laytyp=active)

change od and ad to unique_ptr

Member Acts::ConeLayer::create (const Transform3 &transform, std::shared_ptr< const ConeBounds > cbounds, std::unique_ptr< SurfaceArray > surfaceArray, double thickness=0., std::unique_ptr< ApproachDescriptor > ad=nullptr, LayerType laytyp=active)

change od and ad to unique_ptr

Class Acts::CutoutCylinderVolumeBounds

add sectoral cutouts

Member Acts::CylinderLayer::create (const Transform3 &transform, const std::shared_ptr< const CylinderBounds > &cbounds, std::unique_ptr< SurfaceArray > surfaceArray=nullptr, double thickness=0., std::unique_ptr< ApproachDescriptor > ad=nullptr, LayerType laytyp=passive)

ApproachDescriptor to unique_ptr

Member Acts::CylinderLayer::CylinderLayer (const Transform3 &transform, const std::shared_ptr< const CylinderBounds > &cBounds, std::unique_ptr< SurfaceArray > surfaceArray=nullptr, double thickness=0., std::unique_ptr< ApproachDescriptor > ades=nullptr, LayerType laytyp=passive)

change ApproachDescriptor to unique_ptr

Namespace Acts::DetrayJsonHelper

Move this to the ActsPlugins namespace

Member Acts::DetrayJsonHelper::maskFromBounds (const Acts::SurfaceBounds &sBounds, bool portal=false)

change to detray imports when available annulus2 = 0u, cuboid3 = 1u, cylinder2 = 2u, cylinder3 = 3u, portal_cylinder2 = 4u, rectangle2 = 5u, ring2 = 6u, trapezoid2 = 7u, cell_wire = 8u, straw_wire = 9u, single1 = 10u, single2 = 11u, single3 = 12u, unknown = 13u

Member Acts::DiscLayer::create (const Transform3 &transform, const std::shared_ptr< const DiscBounds > &dbounds, std::unique_ptr< SurfaceArray > surfaceArray=nullptr, double thickness=0., std::unique_ptr< ApproachDescriptor > ad=nullptr, LayerType laytyp=passive)

move ApproachDescriptor to unqique_ptr

Member Acts::DiscSurface::localPolarToCartesian (const Vector2 &lpolar) const

check

Member Acts::HomogeneousVolumeMaterial::material (const Vector3 &position) const final

interface to change including 'cell'

Member Acts::InterpolatedMaterialMap< Mapper_t >::getMaterialGradient (const Vector3 &position, ActsMatrix< 5, 5 > &) const

return derivative

Member Acts::InterpolatedMaterialMap< Mapper_t >::getMaterialGradient (const Vector3 &position, ActsMatrix< 5, 5 > &, Cache &) const

return derivative

Class Acts::ITrackingVolumeHelper

add documentation how this is done

Member Acts::IVolumeMaterial::material (const Vector3 &position) const =0

interface to change including 'cell'

Member Acts::Layer::m_nextLayerUtility

check if this is needed

Class Acts::ProtoLayerHelper

write more documentation on how this is done

Member Acts::Surface::boundToFreeJacobian (const GeometryContext &gctx, const Vector3 &position, const Vector3 &direction) const

this mixes track parameterisation and geometry should move to : "Acts/EventData/detail/coordinate_transformations.hpp"

Member Acts::Surface::freeToBoundJacobian (const GeometryContext &gctx, const Vector3 &position, const Vector3 &direction) const

this mixes track parameterisation and geometry should move to : "Acts/EventData/detail/coordinate_transformations.hpp"

Member Acts::Surface::freeToPathDerivative (const GeometryContext &gctx, const Vector3 &position, const Vector3 &direction) const

this mixes track parameterisation and geometry should move to : "Acts/EventData/detail/coordinate_transformations.hpp"

Class Acts::SurfaceArrayCreator

write more documentation on how this is done

Class Acts::TrapezoidBounds

can be speed optimized by calculating kappa/delta and caching it

Member ActsFatras::StandardChargedElectroMagneticInteractions

Bethe-Bloch does not describe electrons; add correct ionisation loss descriptions for electrons.

Bethe-Heitler is applied after energy loss and thus sees the wrong input energy.

Member ActsPlugins::GeoModelDetectorElementITk::convertFromGeomodel (std::shared_ptr< GeoModelDetectorElement > detEl, std::shared_ptr< Acts::Surface > srf, const Acts::GeometryContext &gctx, int hardware, int barrelEndcap, int layerWheel, int etaModule, int phiModule, int side)

Remove redundancy in signature once plugin is refactored

Class ActsPlugins::TGeoDetectorElement

what if shape conversion fails? add implementation of more than one surface per module, implementing also for other shapes->Cone,ConeSeg,Tube? what if not used with DD4hep?